Here's what I do, and it works very well for me.

I figured out a tight budget; bills, food, critter care, gas etc. I have that much (plus a little extra) direct deposited into my checking account and anything above that amount goes directly into my savings account. Once it's in savings I try really hard to leave it there, and mostly I do. If I 'borrow' from savings I pay myself back.
I rarely carry cash, too easy to spend. I use my bank card, if the money is not in my checking account then I can't spend it on stuff I don't need (like that new phone I just bought. lol).
I had no credit card for years and years and years, I do have a Home Depot one now as I recently bought a house. It was all paid off but I just bought some yard tools with it (because I just bought that new phone too!) but will pay it off in full when the bill comes in.

I like the envelope idea, as long as you leave the envelopes alone it should work well. It's sort of what I do, I schedule my bills to go out and deduct that amount from my register, so it's not showing therefore, not there.

I've tried very hard to teach my son the value of spending within his means and he now has a modest savings account that he is proud of. He makes very little but covers his bills and living expenses and manages to save a bit.

It takes time to get yourself on track and diligence to stay on track, you just have to figure what works for you.

Good luck!